RFR (S): JDK-8056242: Add function to return structured information about loaded libraries.

[Dmitry Samersoff]

Fredrik,

os_bsd.cpp:1690 the code is Apple specific so it should be under #ifdef

os_linux.cpp:2125 it might be better to use /proc/self/maps

os_solaris.cpp:1740,1749 dlclose have to be here

-Dmitry

On 2014-09-01 16:05, Fredrik Arvidsson wrote:
> Hi
> 
> Here is an updated version of the patch. Thanks for the comments.
> 
> Webrev: http://cr.openjdk.java.net/~farvidsson/8056242/webrev.01/index.html
> 
> /Fredrik
> 
> On 2014-08-28 16:21, Staffan Larsen wrote:
>> Hi Fredrik,
>>
>> A couple of comments:
>> - I would prefer if the new callback was unified with the one that
>> exists on Windows so that we have only on callback-based API for
>> listing dynamic libraries.
>> - If you do that, then would you also clean up enumerate_modules() on
>> windows to get rid of the non-NT support?
>> - Smaller: I think “address” is a better type to use instead of “u8”.
>>
>> Thanks
>> /Staffan
>>
>>
>> On 28 aug 2014, at 15:54, Fredrik Arvidsson
>> <fredrik.arvidsson at oracle.com> wrote:
>>
>>> Hi
>>>
>>> Please help me review this small enhancement.
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~farvidsson/8056242/webrev.00/index.html
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8056242
>>>
>>> Cheers
>>> /F
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.