RFR(XS): 8056994: sun/tools/jstatd/TestJstatdPortAndServer.java and sun/tools/jstatd/TestJstatdServer.java miss correct check of RMI server availability

[Yekaterina Kantserova]

Jaroslav, Dmitry, thank you for your reviews!

Jaroslav, could you please be my sponsor and push the fix? The patch is attached to this mail and includes Dmitry's suggestion for syntax.

Thanks,
Katja



----- Original Message -----
From: jaroslav.bachorik at oracle.com
To: yekaterina.kantserova at oracle.com
Cc: serviceability-dev at openjdk.java.net
Sent: Monday, September 1, 2014 4:13:17 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna
Subject: Re: RFR(XS): 8056994: sun/tools/jstatd/TestJstatdPortAndServer.java and sun/tools/jstatd/TestJstatdServer.java miss correct check of RMI server availability

Reviewed!

-JB-

On 09/01/2014 04:09 PM, Yekaterina Kantserova wrote:
> Please find the updated webrev here:
> http://cr.openjdk.java.net/~ykantser/8056994/webrev.01/
>
> Thanks,
> Katja
>
>
>
> On 09/01/2014 03:47 PM, Jaroslav Bachorik wrote:
>> Hi Katja,
>>
>> On 09/01/2014 02:04 PM, Yekaterina Kantserova wrote:
>>> Hi,
>>>
>>> Could I please have a review of this small fix.
>>>
>>> webrev: http://cr.openjdk.java.net/~ykantser/8056994/webrev.00/
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8056994
>>
>> I would recommend moving the code from L154-157 before the start of
>> the while loop and simplify it with
>> `String remoteHost = serverName != null ? serverName : "JStatRemoteHost"`
>>
>> Cheers,
>>
>> -JB-
>>
>>>
>>> Thanks,
>>> Katja
>>>
>>
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 8056994.1.patch
Type: text/x-patch
Size: 1316 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20140902/45681c65/8056994.1.patch>