RFR: 8057776 Misc cleanups of the attach code

[Staffan Larsen]

Thanks for testing it out.

/Staffan

On 8 sep 2014, at 19:34, Volker Simonis <volker.simonis at gmail.com> wrote:

> Hi Staffan,
> 
> I've just successfully built on AIX with your proposed changes.
> 
> Everything looks fine, so thumbs up from me and thanks for pushing the additional changes!
> 
> Regards,
> Volker
> 
> 
> 
> On Mon, Sep 8, 2014 at 3:04 PM, Staffan Larsen <staffan.larsen at oracle.com> wrote:
> Hi Volker,
> 
> Unfortunately I had already pushed the change. I filed a new bug for the AIX work: JDK-8057778 and the changes are below. If you can review them, I will push it soon.
> 
> Thanks and sorry I forgot aix,
> /Staffan
> 
> 
> diff --git a/src/jdk.attach/aix/classes/sun/tools/attach/AttachProviderImpl.java b/src/jdk.attach/aix/classes/sun/tools/attach/AttachProviderImpl.java
> --- a/src/jdk.attach/aix/classes/sun/tools/attach/AttachProviderImpl.java
> +++ b/src/jdk.attach/aix/classes/sun/tools/attach/AttachProviderImpl.java
> @@ -28,8 +28,6 @@
>  import com.sun.tools.attach.VirtualMachine;
>  import com.sun.tools.attach.VirtualMachineDescriptor;
>  import com.sun.tools.attach.AttachNotSupportedException;
> -import com.sun.tools.attach.spi.AttachProvider;
> -
>  import java.io.IOException;
> 
>  // Based on linux/classes/sun/tools/attach/AttachProviderImpl.java.
> @@ -40,9 +38,6 @@
>   */
>  public class AttachProviderImpl extends HotSpotAttachProvider {
> 
> -    // perf counter for the JVM version
> -    private static final String JVM_VERSION = "java.property.java.vm.version";
> -
>      public AttachProviderImpl() {
>      }
> 
> diff --git a/src/jdk.attach/aix/classes/sun/tools/attach/VirtualMachineImpl.java b/src/jdk.attach/aix/classes/sun/tools/attach/VirtualMachineImpl.java
> --- a/src/jdk.attach/aix/classes/sun/tools/attach/VirtualMachineImpl.java
> +++ b/src/jdk.attach/aix/classes/sun/tools/attach/VirtualMachineImpl.java
> @@ -25,14 +25,12 @@
>   */
>  package sun.tools.attach;
> 
> -import com.sun.tools.attach.VirtualMachine;
>  import com.sun.tools.attach.AgentLoadException;
>  import com.sun.tools.attach.AttachNotSupportedException;
>  import com.sun.tools.attach.spi.AttachProvider;
>  import java.io.InputStream;
>  import java.io.IOException;
>  import java.io.File;
> -import java.util.Properties;
> 
>  // Based on linux/classes/sun/tools/attach/VirtualMachineImpl.java.
> 
> 
> On 8 sep 2014, at 14:48, Volker Simonis <volker.simonis at gmail.com> wrote:
> 
>> hi Staffen,
>> 
>> the change looks good, but could you please also change src/jdk.attach/aix/classes/sun/tools/attach/AttachProviderImpl.java
>> 
>> Thanks,
>> Volker
>> 
>> 
>> 
>> On Mon, Sep 8, 2014 at 2:45 PM, Staffan Larsen <staffan.larsen at oracle.com> wrote:
>> Thank you, all.
>> 
>> On 8 sep 2014, at 14:39, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:
>> 
>> > Hi Staffan,
>> >
>> > Looks good!
>> >
>> > -- daniel
>> >
>> > On 9/8/14 2:23 PM, Staffan Larsen wrote:
>> >> Please review this simple fix for some small issues in the attach code:
>> >> - Removed unused imports
>> >> - Removed unused fields
>> >> - Update @since for startManagementAgent() and startLocalManagementAgent() since these were just backported to 1.8
>> >> - Simplified a for-loop in a test
>> >>
>> >> bug: https://bugs.openjdk.java.net/browse/JDK-8057776
>> >> webrev: http://cr.openjdk.java.net/~sla/8057776/webrev.00/
>> >>
>> >> Thanks,
>> >> /Staffan
>> >>
>> >
>> 
>> 
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20140908/8e60ce0f/attachment-0001.html>