Review request: 8042205: javax/management/monitor/*: some test didn't get all the notifications
shanliang
shanliang.jiang at oracle.com
Mon Sep 15 14:59:18 UTC 2014
Daniel Fuchs wrote:
> Looks good Shanliang.
>
> The synchronization is a bit strange, with the flag being
> volatile and sometime modified within synchronized blocks and
> sometime being modified outside of any s-block, but I believe
> it is working (AFAIU the synchronized is mostly needed because
> you call notifyAll() and wait() and the fact that the flag is
> also modified within the block is just coincidence ;-) ).
> I'm OK with this.
Indeed it is not necessary to modify the flag within the
synchronization, but is harmless and "coincidence".
Here is the new version with the modification for test/ProblemList.txt,
simply removing the tests modified.
http://cr.openjdk.java.net/~sjiang/JDK-8042205/01/
Thanks,
Daniel
>
> -- daniel
>
> On 9/15/14 3:05 PM, shanliang wrote:
>> Hi,
>>
>> Please review the following fix, I changed the way to check received
>> notifications.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8042205
>> Webrec: http://cr.openjdk.java.net/~sjiang/JDK-8042205/00/
>> <http://cr.openjdk.java.net/%7Esjiang/JDK-8042205/00/>
>>
>> Thanks, shanliang
>>
>
More information about the serviceability-dev
mailing list