Codereview request: 8050115 javax/management/monitor/GaugeMonitorDeadlockTest.java fails intermittently

shanliang shanliang.jiang at oracle.com
Tue Sep 16 21:01:40 UTC 2014


David Holmes wrote:
> Hi Shanliang,
>
> On 16/09/2014 7:12 PM, shanliang wrote:
>> Hi,
>>
>> Please review the following fix:
>
> I don't see any functional change. You seem to have replaced a 
> built-in timeout with the externally applied test harness timeout.
Yes no functional change here, we thought that the test needed more time 
to wait a change if a testing VM or machine was really slow, the test 
harness timeout was the maximum time we could give the test. 
>
> Style nit: add a space after 'while' -> while (cond) {
OK, I will do it before pushing.

Thanks,
Shanliang
>
> David
> -----
>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8050115
>> webrev: http://cr.openjdk.java.net/~sjiang/JDK-8050115/00/
>>
>> Thanks,
>> Shanliang



More information about the serviceability-dev mailing list