Codereview request: 8050115 javax/management/monitor/GaugeMonitorDeadlockTest.java fails intermittently

Daniel Fuchs daniel.fuchs at oracle.com
Wed Sep 17 15:22:21 UTC 2014


On 9/17/14 5:09 PM, shanliang wrote:
>> This looks much better, thanks.
>> May I suggested taking the current time again at lines 125
>> and 179:
>>
>>    checkedTime = System.currentTimeMillis();
>>
>> It would allow to discount the time spent in checking.
> Here is the new version with your suggestion to re-calculate checkedTime.
>
> http://cr.openjdk.java.net/~sjiang/JDK-8050115/04/
>
> Thanks a lot for your time!
> Shanliang

Looks good Shanliang!

Thanks a lot for your patience ;-)

-- daniel


More information about the serviceability-dev mailing list