RFR(S): JDK-8054194 jstack crash: assert(handle != NULL) failed: JNI handle should not be null
Staffan Larsen
staffan.larsen at oracle.com
Wed Sep 24 09:50:10 UTC 2014
Wouldn’t “path == NULL” be more idiomatic than “path == 0”?
On a process note, I think it would be better if you push this fix with a new bug and leave the original bug (8054194) open. I think this is better since you are not really fixing 8054194. The new bug could say something like “SA: add value checking in setImageAndSymbolPath()”.
Thanks,
/Staffan
On 24 sep 2014, at 11:36, Dmitry Samersoff <dmitry.samersoff at oracle.com> wrote:
> Hi Everybody,
>
> Please review the fix:
>
> http://cr.openjdk.java.net/~dsamersoff/JDK-8054194/webrev.02/
>
> Time to time, attaching jstack to test being killed by timeout, we get a
> secondary crash from JVM running jstack. The crash is intermittent and
> hard to reproduce.
>
> This fix doesn't address the root cause (I'm going to file a new CR to
> have it investigated) but intended to reduce a noise in nightly tests -
> we will get meaningful exception from jstack rather than VM crash.
>
> -Dmitry
>
> --
> Dmitry Samersoff
> Oracle Java development team, Saint Petersburg, Russia
> * I would love to change the world, but they won't give me the sources.
More information about the serviceability-dev
mailing list