RFR(XS): 8027668: sun/tools/jstatd/TestJstatdPort.java: java.net.ConnectException: Connection refused: connect

[Yekaterina Kantserova]

Hi,

The updated webrev can be found here: 
http://cr.openjdk.java.net/~ykantser/8027668/webrev.01/

Thanks,
Katja



On 04/02/2015 02:44 PM, Jaroslav Bachorik wrote:
> Hi Katja,
>
> On 2.4.2015 14:16, Yekaterina Kantserova wrote:
>> Hi,
>>
>> Could I please have a review of this fix.
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8027668
>> webrev: http://cr.openjdk.java.net/~ykantser/8027668/webrev.00/
>
> In src/jdk.jvmstat/share/classes/sun/tools/jstatd/Jstatd.java I would 
> suggest adding System.out.flush() after printing "jstatd is started on 
> ..." to make sure the output is actually committed to stdout.
>
> Please, update the copyright years.
>
> -JB-
>
>>
>> The tests can still contain a race. There is a possibility the jstad is
>> not really started though there is a pid for the process. The suggestion
>> is to let jstatd notify it's started and for the test wait until this
>> notification.
>>
>> Thanks,
>> Katja
>