RFR(M): 8059047: Extract parser/validator from jhat for use in tests

[Yekaterina Kantserova]

Thanks for the catch Staffan! I'll go through all of them and send out a new webrev.

// Katja



----- Original Message -----
From: staffan.larsen at oracle.com
To: staffan.larsen at oracle.com
Cc: yekaterina.kantserova at oracle.com, serviceability-dev at openjdk.java.net, hotspot-dev at openjdk.java.net
Sent: Wednesday, April 22, 2015 3:09:35 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna
Subject: Re: RFR(M): 8059047: Extract parser/validator from jhat for use in tests

Oh, and: serviceability/dcmd/gc/HeapDumpTest.java

> On 22 apr 2015, at 15:06, Staffan Larsen <staffan.larsen at oracle.com> wrote:
> 
> I also found this test that uses jhat and needs an update: com/sun/management/HotSpotDiagnosticMXBean/DumpHeap.sh
> 
> /Staffan
> 
>> On 22 apr 2015, at 15:05, Staffan Larsen <staffan.larsen at oracle.com> wrote:
>> 
>> I think you are missing a "@build jdk.test.lib.hprof..*”.
>> 
>> /Staffan
>> 
>>> On 22 apr 2015, at 14:25, Yekaterina Kantserova <yekaterina.kantserova at oracle.com> wrote:
>>> 
>>> Staffan, thank you for the review!
>>> 
>>> This issue needs a change in jdk as well. http://cr.openjdk.java.net/~ykantser/8059047.jdk/webrev.00 - BasicJMapTest.java will use HprofParser to verify hprof dumps created by the test.
>>> 
>>> // Katja
>>> 
>>> 
>>> 
>>> On 04/22/2015 01:20 PM, Staffan Larsen wrote:
>>>> Looks good!
>>>> 
>>>> Thanks,
>>>> /Staffan
>>>> 
>>>>> On 22 apr 2015, at 11:17, Yekaterina Kantserova <yekaterina.kantserova at oracle.com> wrote:
>>>>> 
>>>>> Hi,
>>>>> 
>>>>> Could I please have a review of this fix.
>>>>> 
>>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8059047
>>>>> webrev: http://cr.openjdk.java.net/~ykantser/8059047/webrev.00/
>>>>> 
>>>>> This fix is a part of JEP 241: Remove the jhat Tool (https://bugs.openjdk.java.net/browse/JDK-8059039). I suggest to put parser/validator into common test library since the functionality can be useful not only for SVC tools tests but even for some future GC tests.
>>>>> 
>>>>> The old jhat packages have been moved as follows:
>>>>> com.sun.tools.hat.internal.model -> jdk.test.lib.hprof.model
>>>>> com.sun.tools.hat.internal.parser -> jdk.test.lib.hprof.parser
>>>>> com.sun.tools.hat.internal.util -> jdk.test.lib.hprof.util
>>>>> 
>>>>> The source has not been changed except Copyrights year.
>>>>> 
>>>>> Thanks,
>>>>> Katja
>>> 
>> 
>