RFR: 8133245 Use external.lib.roots instead of relative paths for @library

[Jaroslav Bachorik]

On 10.8.2015 05:19, Staffan Larsen wrote:
>
>> On 10 aug 2015, at 14:03, Jaroslav Bachorik
>> <jaroslav.bachorik at oracle.com <mailto:jaroslav.bachorik at oracle.com>>
>> wrote:
>>
>> Hi Staffan,
>>
>> On 10.8.2015 01:19, Staffan Larsen wrote:
>>> jtreg @library entries like these:
>>>
>>>  @library /../../test/lib
>>>
>>> which refer to classes in the top-level repo, can be changed to
>>>
>>>   * @library /test/lib
>>>
>>> if external.lib.roots=../../ is added to TEST.ROOT. This is a new
>>> feature in jtreg 4.1b12 (which we are currently using).
>>>
>>> Please review the changes to the serviceability tests to incorporate
>>> this:
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8133245
>>> webrev hotspot:
>>> http://cr.openjdk.java.net/~sla/8133245/hotspot/webrev.00/
>>
>> Looks good.
>>
>>> webrev jdk:http://cr.openjdk.java.net/~sla/8133245/jdk/webrev.00/
>>
>> test/TEST.ROOT - shouldn't there be '4.1 b12' instead of '4.1 b11’?
>
> Yes, it does say ‘4.1 b12’:
> http://cr.openjdk.java.net/~sla/8133245/jdk/webrev.00/test/TEST.ROOT.udiff.html

I completely missed it :(

In that case - ship it!

-JB-

>
> /Staffan
>
>>
>> Otherwise looks good too.
>>
>> -JB-
>>
>>>
>>> Thanks,
>>> /Staffan
>