RFR: JDK-8134458 Make sun/tools/jps tests non-concurrent with other tests

[Staffan Larsen]

Thanks!

> On 25 aug 2015, at 21:39, Martin Buchholz <martinrb at google.com> wrote:
> 
> Looks ... OK!
> 
> On Tue, Aug 25, 2015 at 9:32 PM, Staffan Larsen <staffan.larsen at oracle.com <mailto:staffan.larsen at oracle.com>> wrote:
> 
>> On 25 aug 2015, at 19:53, Martin Buchholz <martinrb at google.com <mailto:martinrb at google.com>> wrote:
>> 
>> But it is a workaround that only reduces flakiness, right?  If two jtreg invocations are on the same machine running concurrently, we still have a risk of failure?
> 
> Yes, but they have to be run by the same user and we “never do that”. This isn’t the final fix for the tests, just a quick fix to get the tests to be mor stable in our CI server.
> 
> /Staffan
> 
>> 
>> On Tue, Aug 25, 2015 at 4:26 PM, Staffan Larsen <staffan.larsen at oracle.com <mailto:staffan.larsen at oracle.com>> wrote:
>> A new test (tools/launcher/ArgFileSyntax.java) was recently added. One of the things that test does is create command lines with newlines in them. If this is run at the same time as the jps tests, the regexp in the jps tests fails on the newlines in the output. A simple workaround for this is to make sure the jps tests are not being run together with the other tests. We do this by adding the test path to exclusiveAccess.dirs in JTREG.ROOT.
>> 
>> bug: https://bugs.openjdk.java.net/browse/JDK-8134458 <https://bugs.openjdk.java.net/browse/JDK-8134458>
>> 
>> Thanks,
>> /Staffan
>> 
>> 
>> diff --git a/test/TEST.ROOT b/test/TEST.ROOT
>> --- a/test/TEST.ROOT
>> +++ b/test/TEST.ROOT
>> @@ -18,7 +18,7 @@
>>  othervm.dirs=java/awt java/beans javax/accessibility javax/imageio javax/sound javax/print javax/management com/sun/awt sun/awt sun/java2d sun/pisces javax/xml/jaxp/testng/validation java/lang/ProcessHandle
>> 
>>  # Tests that cannot run concurrently
>> -exclusiveAccess.dirs=java/rmi/Naming java/util/prefs sun/management/jmxremote sun/tools/jstatd sun/security/mscapi java/util/stream javax/rmi
>> +exclusiveAccess.dirs=java/rmi/Naming java/util/prefs sun/management/jmxremote sun/tools/jstatd sun/security/mscapi java/util/stream javax/rmi sun/tools/jps
>> 
>>  # Group definitions
>>  groups=TEST.groups [closed/TEST.groups]
>> 
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20150826/e3698726/attachment-0001.html>