RFR: 8144220: UL does not support full path names for log files on windows

[Bengt Rutisson]

Hi Marcus,

On 2015-12-02 15:28, Marcus Larsson wrote:
> Hi Bengt,
>
> Thanks for looking at this.
>
> On 2015-12-02 14:59, Bengt Rutisson wrote:
>>
>> Hi Marcus,
>>
>> On 2015-12-02 14:41, Marcus Larsson wrote:
>>>  Hi,
>>>
>>> Please review the following patch to allow full path names for log 
>>> files on windows.
>>>
>>> The full path to files will on windows contain a colon (from the C:\ 
>>> part), and there used to be no way to avoid that colon from being 
>>> parsed as the delimiter for the next -Xlog: option. With this patch 
>>> it is now possible to avoid this by giving the path within quotation 
>>> marks, for example: -Xlog:all:"C:\out.log". Any colons within quotes 
>>> will not be parsed as delimiters for -Xlog.
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~mlarsson/8144220/webrev.00/
>>
>> As far as I can tell this looks good.
>>
>> I would like to have a few more cases in the test though. The way you 
>> have designed your test you can easily test for cases that are wrong 
>> too. For example non-closed quotes etc.
>>
>> Could you add a couple of more test cases? Maybe:
>>
>> -Xlog:all=trace:"
>> -Xlog:all=trace:""
>> -Xlog:all=trace:"""
>
> Good point, I'll add more cases to the test.
>
> I actually wrote some unit tests for this as well, so there are a few 
> additional tests waiting to be checked in once we have unit test support.

Great! This really seems like something that is much better tested in 
unit tests.

Thanks,
Bengt

>
> Thanks,
> Marcus
>
>>
>> Thanks,
>> Bengt
>>
>>>
>>> Issue:
>>> https://bugs.openjdk.java.net/browse/JDK-8144220
>>>
>>> Testing:
>>> New test through RBT.
>>>
>>> Thanks,
>>> Marcus
>>
>