RFR: 8144146: Unified Logging tags cannot be reserved keywords

David Holmes david.holmes at oracle.com
Mon Dec 7 11:16:33 UTC 2015


On 7/12/2015 5:58 PM, Marcus Larsson wrote:
> Hi David,
>
> On 2015-12-07 07:26, David Holmes wrote:
>> Hi Marcus,
>>
>> On 5/12/2015 12:46 AM, Marcus Larsson wrote:
>>> Hi,
>>>
>>> Please review the following patch to allow C++ reserved keywords to be
>>> used as UL tags. This allows usage of a 'class' tag, for example.
>>>
>>> Tags are now automatically prefixed with underscores by the macros. This
>>> means they will still be referred to without underscores when used, but
>>> avoid keyword conflicts.
>>
>> Does the list of available tags show them with or without underscores?
>
> Without.
> Essentially, everything (configuration, printing/listing) will work just
> like before, but "internally" the tags will be prefixed with the
> underscore.

Okay - looks good then.

Thanks,
David


> Thanks,
> Marcus
>
>>
>> Thanks,
>> David
>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~mlarsson/8144146/webrev.00/
>>>
>>> Issue:
>>> https://bugs.openjdk.java.net/browse/JDK-8144146
>>>
>>> Testing:
>>> JPRT testset hotspot
>>>
>>> Thanks,
>>> Marcus
>


More information about the serviceability-dev mailing list