[ping] Re: RFR 8144308: com/sun/jdi/SuspendThreadTest.java failed with "transport error 202: send failed: Broken pipe"

[David Holmes]

On 8/12/2015 6:54 AM, serguei.spitsyn at oracle.com wrote:
> Hi Jaroslav,
>
> Looks good.
> Would it more clean with the "volatile" keyword ?
>
> 45 public static boolean active = true;

If set and read in different threads then it must be volatile. Else C2 
can turn it into an if-check outside an infinite loop.

David

> Thanks,
> Serguei
>
>
> On 12/7/15 00:43, Jaroslav Bachorik wrote:
>> On 1.12.2015 18:33, Jaroslav Bachorik wrote:
>>> Please, review the following simple test change
>>>
>>> Issue : https://bugs.openjdk.java.net/browse/JDK-8144308
>>> Webrev: http://cr.openjdk.java.net/~jbachorik/8144308/webrev.00
>>>
>>> The test keeps the debuggee spinning in a loop and does not stop it once
>>> the testing is over. While the harness usually takes care of this,
>>> occasionally it fails while trying to do that.
>>>
>>> The fix is to add a loop invariant variable and set it to false once we
>>> are done with the debugee and it is ok for it to finish.
>>>
>>> Thanks,
>>>
>>> -JB-
>>
>