RFR: JDK-8144965: Show oop pointer in call frame at HSDB.

[Yasumasa Suenaga]

Hi Jaroslav,

Thank you for your comment.

> L1926 - vf.getLocals().oopHandleAt(0) may return null; the result should
> be checked before calling toString() on it

I've fixed it in new webrev:
  http://cr.openjdk.java.net/~ysuenaga/JDK-8144965/webrev.01/


Could you review again?


Thanks,

Yasumasa


On 2015/12/09 17:45, Jaroslav Bachorik wrote:
> On 9.12.2015 01:59, Yasumasa Suenaga wrote:
>> Hi all,
>>
>> I use HSDB / CLHSDB when I have to analyze coredump image.
>> For example, if JVM is crashed in static JNI method (e.g. ZIP archive operation),
>> I want to find oop (like "this" pointer) address from upper call frame.
>>
>> We can find it from stack, however, it is hard.
>> So I want to show it in each call frame as possible.
>>
>>
>> I've uploaded a webrev:
>>     http://cr.openjdk.java.net/~ysuenaga/JDK-8144965/webrev.00/
>>
>> I'm jdk 9 committer, however, I could not access JPRT.
>> Thus I need a sponsor.
>>
>> Could you help?
>>
>>
>> I want to show Inspect window when oop address is clicked in HSDB.
>> However, it seems hard because HTMLGenerator is generating text, does not have
>> window control.
>>
>> Thus I propose to show oop address.
> 
> http://cr.openjdk.java.net/~ysuenaga/JDK-8144965/webrev.00/agent/src/share/classes/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java.frames.html
> L1926 - vf.getLocals().oopHandleAt(0) may return null; the result should
> be checked before calling toString() on it
> 
> -JB-
> 
>>
>>
>> Thanks,
>>
>> Yasumasa
>>
>