RFR: JDK-5108778 Too many instances of java.lang.Boolean created in Java application(hotspot)

Thu Dec 10 19:51:06 UTC 2015

> On 10 dec. 2015, at 17:58, Sebastian Sickelmann <sebastian.sickelmann at gmx.de> wrote:
> 
> Thanks for the reviews so far.
> 
> I am not sure how the serviceability thing need to be handled. Should
> there be a review-result of a serviceability-member?
> I think nether david or staffan are members of the serviceability-group.

You need reviews from at least one Reviewer and from someone who works in the serviceability area (it can be the same person). You now have two reviews from two Reviewers one of whom (me) works in the serviceability area, so you are good to go.

> If it is not the case here would be the changeset so far. As I am not a
> committer I would need some support to push this.
> 
> http://cr.openjdk.java.net/~sebastian/8145061/webrev.00/ <http://cr.openjdk.java.net/~sebastian/8145061/webrev.00/>

If you send me (privately) the “hg export” output of your patch, with the correct commit message (http://openjdk.java.net/guide/producingChangeset.html#create <http://openjdk.java.net/guide/producingChangeset.html#create>), I can push it for you.

Thanks,
/Staffan

> 
> Don't be confused i have used the sub-task issue-number for the hotspot sub-patch for this webrev and commit-message, to not sideeffect-close the main-issue in the JBS.
> 
> --
> Sebastian
> 
> 
> On 12/10/2015 03:56 PM, Staffan Larsen wrote:
>> Looks good!
>> 
>> Thanks,
>> /Staffan
>> 
>>> On 10 dec. 2015, at 15:44, Coleen Phillimore <coleen.phillimore at oracle.com> wrote:
>>> 
>>> 
>>> Adding serviceability-dev.  They work on this code.
>>> Coleen
>>> 
>>> 
>>> On 12/10/15 12:38 AM, Sebastian Sickelmann wrote:
>>>> @Adding hotspot-runtime-dev
>>>> 
>>>> Hi,
>>>> 
>>>> a want to restart a discussion/review-process for on old "bug" JDK-5108778.
>>>> I created a webrev which is based on the jdk9/dev repo:
>>>> 
>>>> http://cr.openjdk.java.net/~sebastian/5108778/hotspot/webrev.00/
>>>> 
>>>> To enable a subrepo review/push-process I created a subtask for the
>>>> hotspot part of the change which is JDK-8145061.
>>>> 
>>>> The earlier mentioned jtreg-test(see below) was dropped due to some
>>>> initial misunderstandings.
>>>> 
>>>> @Christian: As you initially responded to my first post I want you to
>>>> ask if you want to review / sponsor this fix?
>>>> 
>>>> 
>>>> --
>>>> Sebastian
>>>> 
>>>> 
>>>> 
>>>> On 10/07/2015 09:59 PM, Sebastian Sickelmann wrote:
>>>>> Please find the webrev hosted on openjdk-infrastructure at:
>>>>> 
>>>>> http://cr.openjdk.java.net/~sebastian/5108778/hotspot/webrev.00/
>>>>> 
>>>>> For some general discussion on regression-tests for this please find the
>>>>> thread in discuss[0][1] and for the general suggestion to make more
>>>>> wrapper-type-constructors deprecated find [2] at core-libs-dev.
>>>>> 
>>>>> [0]
>>>>> http://mail.openjdk.java.net/pipermail/discuss/2015-September/003804.html
>>>>> [1] http://mail.openjdk.java.net/pipermail/discuss/2015-October/003805.html
>>>>> [2]
>>>>> http://mail.openjdk.java.net/pipermail/core-libs-dev/2015-October/035642.html
>>>>> 
>>>>> -- Sebastian
>>>>> 
>>>>> On 09/30/2015 07:50 AM, Christian Thalinger wrote:
>>>>>> Sounds good.  If you have the final patch, let us know.
>>>>>> 
>>>>>>> On Sep 29, 2015, at 5:38 PM, Sebastian Sickelmann <sebastian.sickelmann at gmx.de> wrote:
>>>>>>> 
>>>>>>> Yes it is the only (non-test) source i could find in hotspot, but i want
>>>>>>> to change it in all openjdk sources i can find it.
>>>>>>> I thought i really must discuss it part by part in the mailing-lists.
>>>>>>> Actually i am working on the issue to save against regression on this.
>>>>>>> Thanks Alexandr for this input. So there will be something that
>>>>>>> integrates into jtreg for this too.
>>>>>>> 
>>>>>>> -- Sebastian
>>>>>>> 
>>>>>>> 
>>>>>>> On 09/30/2015 01:11 AM, Christian Thalinger wrote:
>>>>>>>> Thanks for volunteering to look into such old bugs!
>>>>>>>> 
>>>>>>>> Is this the only occurrence of that pattern in the hotspot repository?  If you want to fix this in hotspot only without the jdk changes described in the RFE (I just changed the type from Bug to Enhancement) then we have to file a new RFE because we can’t close the original one.
>>>>>>>> 
>>>>>>>>> On Sep 27, 2015, at 6:58 AM, Sebastian Sickelmann <sebastian.sickelmann at gmx.de> wrote:
>>>>>>>>> 
>>>>>>>>> Hello,
>>>>>>>>> 
>>>>>>>>> my name is Sebastian Sickelmann and i signed the OCA.
>>>>>>>>> 
>>>>>>>>> Actually I am searching through the JBS for low hanging fruits.
>>>>>>>>> Right now i am looking through the openjdk-sources and try to evaluate
>>>>>>>>> if i can make something about JDK-5108778.
>>>>>>>>> 
>>>>>>>>> As I am not an author, I am actually not able to host webrevs on
>>>>>>>>> cr.openjdk.java.net.
>>>>>>>>> 
>>>>>>>>> Is there someone who would support at hosting the hotspot-part of
>>>>>>>>> JDK-5108778 on cr.openjdk.java.net for reviewing?
>>>>>>>>> 
>>>>>>>>> I placed the hotspot part in my dropbox at:
>>>>>>>>> https://dl.dropboxusercontent.com/u/43692695/oss-patches/openjdk/jdk-5108778/hotspot_0/webrev/index.html
>>>>>>>>> or as zip:
>>>>>>>>> https://dl.dropboxusercontent.com/u/43692695/oss-patches/openjdk/jdk-5108778/hotspot_0/webrev.zip
>>>>>>>>> 
>>>>>>>>> I executed all jtreg tests in hotspot/test and get no more errors than before the change.
>>>>>>>>> 
>>>>>>>>> -- Sebastian
>>>>>>>>> 
>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20151210/b9efda0d/attachment.html>