RFR: 8145153: Convert TraceMonitorInflation to Unified Logging

David Holmes david.holmes at oracle.com
Fri Dec 11 00:53:52 UTC 2015


Hi Rachel,

On 11/12/2015 8:21 AM, Rachel Protacio wrote:
> Hello!
>
> Please review another product flag logging change. This one's pretty
> small. Converts TraceMonitorInflation to -Xlog:monitorinflation=debug

Conversion looks fine.

> internally, with an alias for the old option. I've again patched in
> Max's alias table code in the arguments.cpp and .hpp files since my
> previous changeset with that code is currently on hold.

I still have an unanswered question from the other thread about how the 
order of options is handled. Primarily whether left-to-right processing 
prevails?

I also strongly believe we should be deprecating these flags at the same 
time we do the conversion as this is a classic case of deprecation if 
ever there was one!

> Open webrev: http://cr.openjdk.java.net/~rprotacio/8145153/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8145153

On the test, if you use the testlibrary you must also @build it.

Also java -version is sufficient to see some inflating/deflating happen, 
and your sample class does nothing to force inflation.

Thanks,
David



> Testing: passes jck vm tests, JPRT, and RBT quick and noncolo tests
>
> Thank you!
> Rachel


More information about the serviceability-dev mailing list