[PING] Re: RFR: 8144220: UL does not support full path names for log files on windows

[Markus Gronlund]

Hi Marcus,

This looks good.

Thanks
Markus

-----Original Message-----
From: Marcus Larsson 
Sent: den 11 december 2015 13:49
To: serviceability-dev at openjdk.java.net
Subject: [PING] Re: RFR: 8144220: UL does not support full path names for log files on windows

Need another review for this.

On 2015-12-03 11:11, Marcus Larsson wrote:
> Hi,
>
> New webrev:
> http://cr.openjdk.java.net/~mlarsson/8144220/webrev.01/
>
> Incremental:
> http://cr.openjdk.java.net/~mlarsson/8144220/webrev.00-01/
>
> Added more test cases to the test, and renamed it to 
> TestQuotedLogOutputs.
> The updated test found that partially quoted output names that didn't 
> start with the quote character were accepted. This has been fixed.
>
> Test passes in RBT.
>
> Thanks,
> Marcus
>
> On 2015-12-02 14:41, Marcus Larsson wrote:
>> Hi,
>>
>> Please review the following patch to allow full path names for log 
>> files on windows.
>>
>> The full path to files will on windows contain a colon (from the C:\ 
>> part), and there used to be no way to avoid that colon from being 
>> parsed as the delimiter for the next -Xlog: option. With this patch 
>> it is now possible to avoid this by giving the path within quotation 
>> marks, for example: -Xlog:all:"C:\out.log". Any colons within quotes 
>> will not be parsed as delimiters for -Xlog.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~mlarsson/8144220/webrev.00/
>>
>> Issue:
>> https://bugs.openjdk.java.net/browse/JDK-8144220
>>
>> Testing:
>> New test through RBT.
>>
>> Thanks,
>> Marcus
>