RFR 8062303: Remove com.sun.tracing API

[Staffan Larsen]

Looks good!

Thanks,
/Staffan

> On 5 feb 2015, at 16:06, Jaroslav Bachorik <jaroslav.bachorik at oracle.com> wrote:
> 
> On 5.2.2015 10:48, David Holmes wrote:
>> On 5/02/2015 7:39 PM, Jaroslav Bachorik wrote:
>>> On 5.2.2015 10:26, David Holmes wrote:
>>>> On 5/02/2015 7:16 PM, Jaroslav Bachorik wrote:
>>>>> Please, review the following removal of functionality
>>>>> 
>>>>> Issue : https://bugs.openjdk.java.net/browse/JDK-8062303
>>>>> Webrev: http://cr.openjdk.java.net/~jbachorik/8062303/webrev.00
>>>>> 
>>>>> This API was introduced in JDK7 and immediately made
>>>>> proprietary/unsupported [1]. It didn't see any uptake since then. It'll
>>>>> not be accessible when it moves to modules.
>>>>> 
>>>>> The proposed solution is to drop this proprietary API completely.
>>>> 
>>>> The change in make/lib/Lib-jdk.runtime.gmk seems related to the JSDT
>>>> removal. Is it included by mistake?
>>> 
>>> No. The JSDT implementation depends on com.sun.tracing API (it
>>> implements it) and it must be removed together with the API.
>> 
>> Ah I see. In that case you seem to have overlooked the removal of:
>> 
>> jdk/src/jdk.runtime/unix/native/libjsdt/jvm_symbols_md.c
>> jdk/src/jdk.runtime/windows/native/libjsdt/jvm_symbols_md.c
> 
> ... and they are gone - http://cr.openjdk.java.net/~jbachorik/8062303/webrev.02/ <http://cr.openjdk.java.net/~jbachorik/8062303/webrev.02/>
> 
> I re-ran the tests successfully.
> 
> -JB-
> 
>> 
>> Thanks,
>> David
>> 
>>> The request for the removal of the hotspot JSDT integration was reviewed
>>> in
>>> http://mail.openjdk.java.net/pipermail/hotspot-dev/2015-January/016800.html <http://mail.openjdk.java.net/pipermail/hotspot-dev/2015-January/016800.html>
>>> 
>>> 
>>> -JB-
>>> 
>>>> 
>>>> Otherwise seems like a complete removal from the OpenJDK sources.
>>>> 
>>>> Thanks,
>>>> David
>>>> 
>>>>> Thanks,
>>>>> 
>>>>> -JB-

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20150205/e2036101/attachment-0001.html>