RFR(S, testonly): JDK-8072835 sun/tools/jmap/heapconfig/JMapHeapConfigTest.java Key MaxHeapSize doesn't match

[Staffan Larsen]

I don’t think you need to respect -Xmx if it set from outside. We know that this test is not testing -Xmx, it is just using that flag to check that jmap works. You can override the value of -Xmx in two ways: 1) either set your value before or after the other value (I don’t know which value takes precedence) so that your value is the one that is used, or 2) use Utils.getFilteredTestJavaOpts() to remove any -Xmx flags from the VM options before adding yours.

desiredMaxHeapSize should say “-Xmx128” not “-Xms128”.

/Staffan

> On 10 feb 2015, at 16:39, Dmitry Samersoff <dmitry.samersoff at oracle.com> wrote:
> 
> Hi Everyone,
> 
> Please review the changes:
> 
> http://cr.openjdk.java.net/~dsamersoff/JDK-8072835/webrev.01/
> 
> if maximum heap size is not specified explicitly JVM might change this
> value and it wouldn't match one printed on start.
> 
> The fix makes sure that LingeredApp starts with -Xmx option.
> 
> -Dmitry
> 
> -- 
> Dmitry Samersoff
> Oracle Java development team, Saint Petersburg, Russia
> * I would love to change the world, but they won't give me the sources.