RFR(M): JDK-8072395: LingeredAppTest.java and JMapHeapConfigTest.java fail due to LingeredApp ERROR: java.io.IOException: Lock is too old. Aborting
Dmitry Samersoff
dmitry.samersoff at oracle.com
Thu Feb 12 09:17:14 UTC 2015
Staffan,
Fixed in place (press shift-reload)
http://cr.openjdk.java.net/~dsamersoff/JDK-8072395/webrev.04/
-Dmitry
On 2015-02-12 12:03, Staffan Larsen wrote:
> This looks good, except that I agree with Kevin that we should
> silently succeed if SA isn’t allowed to attach. Otherwise we will get
> lots of failures in the testing. Sorry I missed this in the last
> round of internal review.
>
> /Staffan
>
>> On 11 feb 2015, at 23:38, Kevin Walls <kevin.walls at oracle.com>
>> wrote:
>>
>>
>> Hi Dmitry - like it, and particularly like getting shouldSAAttach()
>> in both jdk and hotspot. Yes you're very efficient in just reading
>> that one byte from those one-byte files! 8-)
>>
>> Sorry one more thing... JMapHeapConfigTest.java throws an
>> exception when it doesn't think it will have permission to attach -
>> other tests I think that know they aren't going to work, just print
>> a message and return from main, they don't count this as a failure.
>> I'll leave that for you to decide!...
>>
>> Thanks Kevin
>>
>>
>> On 11/02/2015 10:41, Dmitry Samersoff wrote:
>>> Hi Everybody,
>>>
>>> Please review the changes:
>>>
>>> http://cr.openjdk.java.net/~dsamersoff/JDK-8072395/webrev.04/
>>>
>>>
>>> 1. Removed lock age test, because LingeredApp can run more than
>>> one hour of machine time.
>>>
>>> 2. Added code to check for common environment pitfalls and
>>> produce meaningful diagnostic
>>>
>>> 3. Testlibrary method canPtraceAttachLinux refactored, fixed
>>> yama ptrace_scope check.
>>>
>>> 4. Sync Platfrom.java in hotspot and jdk testlibraries
>>>
>>> -Dmitry
>>>
>>
>
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
More information about the serviceability-dev
mailing list