RFR: 6588467: Add isDaemon() and getPriority() to ThreadInfo
Jeremy Manson
jeremymanson at google.com
Tue Feb 17 17:31:41 UTC 2015
Hey Mandy,
Thanks for taking a look. Are we okay making those changes even though
none of the other methods in ThreadInfo follow those conventions? Not sure
whether consistency matters more or less than doing it right.
Jeremy
On Mon, Feb 16, 2015 at 3:44 PM, Mandy Chung <mandy.chung at oracle.com> wrote:
> Hi Jeremy,
>
> On 2/9/2015 4:51 PM, Jeremy Manson wrote:
>
>> http://cr.openjdk.java.net/~jmanson/6588467/webrev.01/ <
>> http://cr.openjdk.java.net/%7Ejmanson/6588467/webrev.01/>
>>
>>
> The change looks okay to me.
>
> Nit: It would be good for the new methods to replace <tt>...</tt> with
> {@code ...}. line 600, 603 {@code ThreadInfo}. It would be good to add
> {@linkplain Thread#isDaemon daemon thread} or @see Thread#isDaemon .
> Similarly Thread#getPriority.
>
> thanks
> Mandy
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20150217/c51c3e16/attachment.html>
More information about the serviceability-dev
mailing list