Re: RFR 8067982: some jcmd /gc/heap_dump tests failed: hprof output contains warning or error

[fredrik.arvidsson@oracle.com]

Hi
Looks good to me (not a reviewer). 
Thanks for fixing this! 
/Fredrik

Sent from my HTC

----- Reply message -----
From: "Yumin Qi" <yumin.qi at oracle.com>
To: "Jiangli Zhou" <jiangli.zhou at oracle.com>, "hotspot-runtime-dev at openjdk.java.net" <hotspot-runtime-dev at openjdk.java.net>, "serviceability-dev at openjdk.java.net" <serviceability-dev at openjdk.java.net>
Subject: RFR 8067982: some jcmd /gc/heap_dump tests failed: hprof output contains warning or error
Date: Wed, Jan 14, 2015 04:56

Looks good to me. Could you update the copyright year?

Thanks
Yumin

On 1/13/2015 4:50 PM, Jiangli Zhou wrote:
> Hi,
>
> Please review the fix for JDK-8067982 
> <https://bugs.openjdk.java.net/browse/JDK-8067982> (Some jcmd 
> /gc/heap_dump tests failed: hprof output contains warning or error). 
> The jcmd heap_dump tests failed due to incomplete symbol information 
> in the dump output. The shared symbols are not included in the dump 
> output because they are not in the SymbolTable, but in a separate 
> table within the shared archive. The fix is to include the shared 
> symbols when iterating all symbols in 
> SymbolTable::symbols_do(SymbolClosure).
>
>   http://cr.openjdk.java.net/~jiangli/8067982/webrev.00/
>
> Tested with vm.jcmd tests and jprt. All failed jcmd heap dump tests 
> passed with the fix.
>
> Thanks,
> Jiangli
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20150114/78fcf7f9/attachment.html>