RFR (XS): 6661889: thread id on Linux is inconsistent in error and log outputs

[David Holmes]

On 30/07/2015 9:07 AM, Vladimir Kozlov wrote:
> Finally after 7 years, since I filed this bug, it will be fixed :)

I hope it now does what you wanted :)

On its way.

Thanks,
David

> Looks good.
>
> Thanks,
> Vladimir
>
> On 7/29/15 3:31 PM, David Holmes wrote:
>> Hi Jeremy,
>>
>> On 30/07/2015 6:34 AM, Jeremy Manson wrote:
>>> David, can you review/sponsor this, per our conversation of last week?
>>
>> Yes I can sponsor and it is also Reviewed.
>>
>> But I'd like a second review from someone else.
>>
>> Thanks,
>> David
>>
>>> It fixes an issue where, on Linux, some of the Hotspot logging output
>>> identifies threads by pthread_id, and some of it identifies threads by
>>> kernel-level TID.  This happened because Hotspot calls into two
>>> different APIs that provide the thread ID, and developers seem to have
>>> picked which one they call at random.
>>>
>>> The CR makes these APIs consistently use the kernel-level TID, and makes
>>> one of the APIs a thin shim over the other.
>>>
>>> Conversation:
>>> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2015-July/015507.html
>>>
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-6661889
>>> Webrev: http://cr.openjdk.java.net/~jmanson/6661889/webrev.01/
>>>
>>> Jeremy