RFR: 8058470 [jconsole] VM Summary Tab is blank for JDK9's jconsole.
Staffan Larsen
staffan.larsen at oracle.com
Wed Mar 4 19:21:10 UTC 2015
The problem is that the makefiles do "cleanup" of the resource files, accidentally deleting half of some strings. In this case
GC_INFO=Name = ''{0}'', Collections = {1,choice,-1#Unavailable|0#{1,number,integer}}, Total time spent = {2}
becomes
GC_INFO=Name \= ''{0}'', Collections \= {1,choice,-1#
The below diff fixes the problem. I added an extra ^ before the # so that only # at the beginning of the line are treated as comments. I don’t know if this has other implications, though? Should # anywhere on the line be treated as the beginning of a comment? In that case we need to handle the jconsole resource file specially.
Thanks,
/Staffan
diff --git a/make/common/JavaCompilation.gmk b/make/common/JavaCompilation.gmk
--- a/make/common/JavaCompilation.gmk
+++ b/make/common/JavaCompilation.gmk
@@ -393,7 +393,7 @@
$(MKDIR) -p $$(@D)
export LC_ALL=C ; ( $(CAT) $$< && $(ECHO) "" ) \
| $(SED) -e 's/\([^\\]\):/\1\\:/g' -e 's/\([^\\]\)=/\1\\=/g' \
- -e 's/\([^\\]\)!/\1\\!/g' -e 's/#.*/#/g' \
+ -e 's/\([^\\]\)!/\1\\!/g' -e 's/^#.*/#/g' \
| $(SED) -f "$(SRC_ROOT)/make/common/support/unicode2x.sed" \
| $(SED) -e '/^#/d' -e '/^$$$$/d' \
-e :a -e '/\\$$$$/N; s/\\\n//; ta' \
More information about the serviceability-dev
mailing list