RFR: 8074812 More specific error message when the .java_pid well-known file is not secure

[Staffan Larsen]

Hi Martin,

> On 10 mar 2015, at 18:40, Martin Buchholz <martinrb at google.com> wrote:
> 
> It's traditional (at least on Unix) to put the message after a ": " not within parens.
> http://pubs.opengroup.org/onlinepubs/009695399/functions/perror.html <http://pubs.opengroup.org/onlinepubs/009695399/functions/perror.html>

Good point. I’ll change it to “: “.

>  374             if (sb.st_uid != uid) {
>  375                 msg = "file is not owned by the current user";
>  376             } else if (sb.st_gid != gid) {
>  377                 msg = "file's group is not the effective group";
> 
> Why do you use the word "effective" with the gid, but not the uid?

No reason. How do you think I should word it? I’ve been struggling…

/Staffan

> 
> 
> On Tue, Mar 10, 2015 at 3:21 AM, Staffan Larsen <staffan.larsen at oracle.com <mailto:staffan.larsen at oracle.com>> wrote:
> During attach, if the .java_pid file is not secure we currently say "well-known file is not secure". This can be enhanced to say _why_ the file is not considered secure.
> 
> bug: https://bugs.openjdk.java.net/browse/JDK-8074812 <https://bugs.openjdk.java.net/browse/JDK-8074812>
> webrev: http://cr.openjdk.java.net/~sla/8074812/webrev.00/ <http://cr.openjdk.java.net/~sla/8074812/webrev.00/>
> 
> Note that it is safe to call JNU_ReleaseStringPlatformChars after the calls to JNU_ThrowIOException since the latter don’t actually change the control flow.
> 
> Thanks,
> /Staffan
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20150310/a6fd2c1a/attachment.html>