RFR: 8074812 More specific error message when the .java_pid well-known file is not secure

[Staffan Larsen]

> On 11 mar 2015, at 20:37, Martin Buchholz <martinrb at google.com> wrote:
> 
> Producing good error messages is such hard work!

Aye. And so often forgotten.

> 
> Instead of 0%3o, use 0%03o
> Since you want to print the lowest 9 bits of the mode, don't you want & 0x1ff
Absolutely. I opted for the octal representation 0777 instead which seemed fitting here.

new webrev: http://cr.openjdk.java.net/~sla/8074812/webrev.02/ <http://cr.openjdk.java.net/~sla/8074812/webrev.02/>

Thanks,
/Staffan


> 
> On Wed, Mar 11, 2015 at 2:30 AM, Staffan Larsen <staffan.larsen at oracle.com <mailto:staffan.larsen at oracle.com>> wrote:
> Thanks for the feedback. Here is a new version that prints out more details for each of the errors messages. Let me know if you have suggestions for better wording. It also adds an #include for jvm.h that was missing from some of the files (it is needed for jio_snprintf).
> 
> webrev: http://cr.openjdk.java.net/~sla/8074812/webrev.01/ <http://cr.openjdk.java.net/~sla/8074812/webrev.01/>
> 
> /Staffan
> 
>> On 10 mar 2015, at 19:07, Martin Buchholz <martinrb at google.com <mailto:martinrb at google.com>> wrote:
>> 
>> 
>> 
>> On Tue, Mar 10, 2015 at 10:53 AM, Jaroslav Bachorik <jaroslav.bachorik at oracle.com <mailto:jaroslav.bachorik at oracle.com>> wrote:
>> 
>> This just got me thinking - would including [sb.st_uid, uid] and [sb.st_gid, gid] in the error message be of any additional benefit?
>> 
>> Yes.  How much do you want to improve the quality of error messages?
>> 
>> You could use the word "effective" only when effective and real users don't match.
>> You could print out the two mismatched values. 
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20150312/44020b6a/attachment-0001.html>