RFR: JDK-8075586: add @modules as needed to the open hotspot tests

Alexander Kulyakhtin alexander.kulyakhtin at oracle.com
Tue Mar 24 10:48:17 UTC 2015


Could the reviewers, please, have a look at the proposed changes below? 

In addition, we are going to make a change to the TEST.ROOT file as indicated by Staffan in the mail below.

Do you think the changes (plus the one-line change to the TEST.ROOT) can be pushed into the jdk?

Best regards,
Alex

----- Original Message -----
From: staffan.larsen at oracle.com
To: alexander.kulyakhtin at oracle.com
Cc: serviceability-dev at openjdk.java.net, alexandre.iline at oracle.com
Sent: Friday, March 20, 2015 7:39:10 PM GMT +04:00 Abu Dhabi / Muscat
Subject: Re: RFR: JDK-8075586: add @modules as needed to the open hotspot tests

I haven’t looked at the changes in detail, but please change the requiredVersion in TEST.ROOT to 4.1 b11 as part of this change.

Thanks,
/Staffan

> On 20 mar 2015, at 13:16, Alexander Kulyakhtin <alexander.kulyakhtin at oracle.com> wrote:
> 
> Hi,
> 
> Could you, please, review the fix below.
> 
> CR: https://bugs.openjdk.java.net/browse/JDK-8075586
> webrev: http://cr.openjdk.java.net/~tpivovarova/akulyakh/8075586/webrev.00/
> 
> The fix adds @modules keyword to the existing hotspot tests, as needed, so that the tests can access the required API when the new modular architecture is in place.
> 
> Best regards,
> Alex



More information about the serviceability-dev mailing list