RFR: JDK-8075586: add @modules as needed to the open hotspot tests

[Alexander Kulyakhtin]

Hi Christian,

Yes, I have run the tests and they do pass the same as before.

According to your and Lois' comments I'm going to fix the copyrights and resubmit the webrev as soon as I'm done.

Best regards,
Alex

----- Original Message -----
From: christian.tornqvist at oracle.com
To: alexander.kulyakhtin at oracle.com, lois.foltan at oracle.com
Cc: hotspot-dev at openjdk.java.net, serviceability-dev at openjdk.java.net, alexandre.iline at oracle.com
Sent: Tuesday, March 24, 2015 6:07:27 PM GMT +04:00 Abu Dhabi / Muscat
Subject: RE: RFR: JDK-8075586: add @modules as needed to the open hotspot tests

Hi Alex,

I assume you've run all the tests and that they are still passing? 

The @module changes looks good.  As Lois pointed out, you need to update the copyrights and this should be done as part of this change.

Thanks,
Christian

-----Original Message-----
From: serviceability-dev [mailto:serviceability-dev-bounces at openjdk.java.net] On Behalf Of Alexander Kulyakhtin
Sent: Tuesday, March 24, 2015 10:05 AM
To: lois.foltan at oracle.com
Cc: hotspot-dev at openjdk.java.net; serviceability-dev at openjdk.java.net; alexandre.iline at oracle.com
Subject: Re: RFR: JDK-8075586: add @modules as needed to the open hotspot tests

Lois,

Thank you very much for your findings. 

We are going to remove the blank comments as you have suggested. If possible, however, we would prefer to pursue the copyrights issue under a different CR as this is another and not strictly related bulk change, which, probably, can be best achieved by an unrelated, script. 

I believe, there already is a separate CR for updating the copyrights. However if there's no such CR we are going to create a new one.

Do you think it could be possible to have a separate CR for the copyrights issue (and if necessary to submit a new one)?

Best regards,
Alex 


----- Original Message -----
From: lois.foltan at oracle.com
To: yekaterina.kantserova at oracle.com
Cc: serviceability-dev at openjdk.java.net, staffan.larsen at oracle.com, hotspot-dev at openjdk.java.net, alexander.kulyakhtin at oracle.com, alexandre.iline at oracle.com
Sent: Tuesday, March 24, 2015 3:57:54 PM GMT +04:00 Abu Dhabi / Muscat
Subject: Re: RFR: JDK-8075586: add @modules as needed to the open hotspot tests


This looks good, thank you for making these changes!  A couple of comments that I don't feel need another webrev but should be fixed before pushing.

     - copyrights on all the tests need to be updated
     - the following tests have a blank comment line before the new "@modules" line that could be removed
       test/gc/metaspace/TestMetaspacePerfCounters.java
       test/runtime/contended/Basic.java
       test/compiler/jsr292/CreatesInterfaceDotEqualsCallInfo.java
       test/compiler/cpuflags/RestoreMXCSR.java
       test/compiler/debug/VerifyAdapterSharing.java

Thanks,
Lois

On 3/24/2015 8:09 AM, Yekaterina Kantserova wrote:
> Notifying hotspot-dev as well.
>
> // Katja
>
>
>
> On 03/24/2015 11:48 AM, Alexander Kulyakhtin wrote:
>> Could the reviewers, please, have a look at the proposed changes below?
>>
>> In addition, we are going to make a change to the TEST.ROOT file as 
>> indicated by Staffan in the mail below.
>>
>> Do you think the changes (plus the one-line change to the TEST.ROOT) 
>> can be pushed into the jdk?
>>
>> Best regards,
>> Alex
>>
>> ----- Original Message -----
>> From: staffan.larsen at oracle.com
>> To: alexander.kulyakhtin at oracle.com
>> Cc: serviceability-dev at openjdk.java.net, alexandre.iline at oracle.com
>> Sent: Friday, March 20, 2015 7:39:10 PM GMT +04:00 Abu Dhabi / Muscat
>> Subject: Re: RFR: JDK-8075586: add @modules as needed to the open 
>> hotspot tests
>>
>> I haven’t looked at the changes in detail, but please change the 
>> requiredVersion in TEST.ROOT to 4.1 b11 as part of this change.
>>
>> Thanks,
>> /Staffan
>>
>>> On 20 mar 2015, at 13:16, Alexander Kulyakhtin 
>>> <alexander.kulyakhtin at oracle.com> wrote:
>>>
>>> Hi,
>>>
>>> Could you, please, review the fix below.
>>>
>>> CR: https://bugs.openjdk.java.net/browse/JDK-8075586
>>> webrev: 
>>> http://cr.openjdk.java.net/~tpivovarova/akulyakh/8075586/webrev.00/
>>>
>>> The fix adds @modules keyword to the existing hotspot tests, as 
>>> needed, so that the tests can access the required API when the new 
>>> modular architecture is in place.
>>>
>>> Best regards,
>>> Alex
>