RFR 8080663: Use sun.misc.SharedSecrets to allow access from java.management to @ConstructorProperties

[Jaroslav Bachorik]

On 25.5.2015 13:50, Alan Bateman wrote:
>
>
> On 25/05/2015 10:34, Jaroslav Bachorik wrote:
>>
>> Webrev with the merged accessor interface:
>> http://cr.openjdk.java.net/~jbachorik/8080663/webrev.00
> I think you mean:
>    http://cr.openjdk.java.net/~jbachorik/8080663/webrev.01/
>
> I agree this shouldn't require a new test because this code is well
> exercised by existing tests. Best to add a noreg-* label to the JIRA
> issue rather than needlessly adding the JIRA issue number to many tests.

NP. 'noreg-other' should do.

>
> Is there a guarantee that Introspector will be initialized to ensure
> that the secret is set before JavaBeansAccessor methods are invoked? In
> the original code then BeanIntrospector attempts to load
> java.beans.Introspector but I can't see the equivalent in the updated code.

JavaBeansAccessor L39-46 - in the static initializer of this class 
'Class.forName("java.beans.Introspector", true, 
JavaBeansAccessor.class.getClassLoader());' is called.

>
> A minor comment on JavaBeansAccessor is that it would be good to keep
> the line length consistent for the area.

Ok.

>
> Otherwise looks okay to me.

Thanks.

-JB-

>
> -Alan.