RFR 8080663: Use sun.misc.SharedSecrets to allow access from java.management to @ConstructorProperties
Mandy Chung
mandy.chung at oracle.com
Mon May 25 18:27:59 UTC 2015
> On May 25, 2015, at 2:34 AM, Jaroslav Bachorik <jaroslav.bachorik at oracle.com> wrote:
>
>
> Webrev with the merged accessor interface: http://cr.openjdk.java.net/~jbachorik/8080663/webrev.01
>
>
>>
>> Can you add a regression for this, if not exist, as Daniel points out?
>
> There is a bunch of tests exercising the proper handling of @ConstructorAnnotationProperties - I added this issue number to the list of bug ids. Doesn't really seem to be worth adding a separate regtest.
Since there are existing regression tests exercising @CP and Introspector, this is well covered then (it wasn’t clear to me where these existing tests are and hence my comment).
webrev.01 looks good to me. Nit: JavaBeansAccessor and JavaBeansAccess - in the javadoc of getConstructorPropertiesValue method, <b>value</b> and <b>null</b> may be more appropriate to use {@code …}
Mandy
More information about the serviceability-dev
mailing list