RFR: 8141591 : javax/management/remote/mandatory/threads/ExecutorTest.java fails intermittently
Jaroslav Bachorik
jaroslav.bachorik at oracle.com
Mon Nov 9 16:03:19 UTC 2015
Hi Alexander,
On 9.11.2015 16:40, Alexander Kulyakhtin wrote:
> Hi,
>
> Could you, please, review this test-only fix:
>
> CR: https://bugs.openjdk.java.net/browse/JDK-8141591
> Webrev: http://cr.openjdk.java.net/~akulyakh/8141591_01/test/javax/management/remote/mandatory/threads/ExecutorTest.java.udiff.html
>
> Before the fix, it was possible that we shut down the executor before all the jobs have been submitted. This resulted in RejectedExecutionException.
> We are modifying the test to wait on CountDownLatch untill all the jobs have completed their execute()
On L175 you should be using the unbound version of await(). It would be
better to let the harness deal with the timeout.
Otherwise it looks good.
Cheers,
-JB-
>
> Best regards,
> Alexander
>
More information about the serviceability-dev
mailing list