RFR: 8141591 : javax/management/remote/mandatory/threads/ExecutorTest.java fails intermittently

[Alexander Kulyakhtin]

Hi Jaroslav,

Thank you very much for the review.

I wanted to use the bound version of the await(timeout) to provide for a better output in case the test fails.
Would you advise just to replace with no-args await() or is it possible to somehow distinguish for L175 and other platforms where possible?

Best regards,
Alexander

----- Original Message -----
From: jaroslav.bachorik at oracle.com
To: alexander.kulyakhtin at oracle.com, serviceability-dev at openjdk.java.net
Sent: Monday, November 9, 2015 7:03:22 PM GMT +03:00 Iraq
Subject: Re: RFR: 8141591 : javax/management/remote/mandatory/threads/ExecutorTest.java fails intermittently

Hi Alexander,

On 9.11.2015 16:40, Alexander Kulyakhtin wrote:
> Hi,
>
> Could you, please, review this test-only fix:
>
> CR: https://bugs.openjdk.java.net/browse/JDK-8141591
> Webrev: http://cr.openjdk.java.net/~akulyakh/8141591_01/test/javax/management/remote/mandatory/threads/ExecutorTest.java.udiff.html
>
> Before the fix, it was possible that we shut down the executor before all the jobs have been submitted. This resulted in RejectedExecutionException.
> We are modifying the test to wait on CountDownLatch untill all the jobs have completed their execute()

On L175 you should be using the unbound version of await(). It would be 
better to let the harness deal with the timeout.

Otherwise it looks good.

Cheers,

-JB-

>
> Best regards,
> Alexander
>