[PING] Re: RFR (XS): 8142483: Unified logging log instances cause warnings on windows when only static functions are used

Marcus Larsson marcus.larsson at oracle.com
Fri Nov 20 12:29:22 UTC 2015


Need another review for this!

Thanks,
Marcus

On 2015-11-13 10:20, Marcus Larsson wrote:
> Hi,
>
> Please review the following small patch to avoid 'unused variable' 
> warnings on windows when only static functions are used on a log 
> instance. Using log instances like this saves us from specifying the 
> log tags for every function call, so it is something we should not 
> warn about.
>
> The patch adds an empty constructor, which means that at least one 
> non-static function is called for every log instance, and the warning 
> is avoided.
>
> Webrev:
> http://cr.openjdk.java.net/~mlarsson/8142483/webrev.00/
>
> Issue:
> https://bugs.openjdk.java.net/browse/JDK-8142483
>
> Thanks,
> Marcus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20151120/31c05b8d/attachment.html>


More information about the serviceability-dev mailing list