RFR: 8143121: javax/management/remote/mandatory/loading/MethodResultTest.java fails intermittently

[Alexander Kulyakhtin]

Hi Daniel,

Thank you very much for the review.

I presumed that in such case the jtreg will terminate the test by timeout and so I wanted to avoid any specific delays and counters.
If it's not safe to presume that, then I'm going to limit the number of retries to 5 times introducing a delay of 3 seconds between the reties, or I can use any other values if there are more preferable values.

Best regards,
Alexander



 
----- Original Message -----
From: daniel.fuchs at oracle.com
To: alexander.kulyakhtin at oracle.com, serviceability-dev at openjdk.java.net
Sent: Monday, November 23, 2015 2:32:27 PM GMT +03:00 Iraq
Subject: Re: RFR: 8143121: javax/management/remote/mandatory/loading/MethodResultTest.java fails intermittently

Hi Alexander,

This looks a bit dangerous to me - it could create a busy loop
if for some reason the connection can never go through.

I would suggest retrying only once (or retrying a fixed number
of times) - and possibly introducing a small delay (Thread.sleep)
before retrying.

best regards,

-- daniel

On 23/11/15 12:19, Alexander Kulyakhtin wrote:
> Hi,
>
> Could you, please, review this small, test-only, change:
>
> CR: https://bugs.openjdk.java.net/browse/JDK-8143121
> Webrev: http://cr.openjdk.java.net/~akulyakh/8143121/test/javax/management/remote/mandatory/loading/MethodResultTest.java.udiff.html
>
> The precondition for this test is a JMXConnector having established a successful connection.
> On some environments the test sometimes can not connect at the first attempt, because the target application is not yet ready.
> We are changing the test so that it tries to connect again if it gets IOException during the connection.
>
> Best regards,
> Alexander
>