RFR 8134420: sun/tools/jps/TestJpsClass fails with java.lang.RuntimeException: The line 'line 2' does not match pattern '^\\d+\\s+.*': expected true, was false
Jaroslav Bachorik
jaroslav.bachorik at oracle.com
Fri Sep 4 10:56:25 UTC 2015
On 4.9.2015 12:43, Jaroslav Bachorik wrote:
> On 4.9.2015 12:35, Staffan Larsen wrote:
>> Oh - you should also remove the entries in ProblemList.txt.
>
> Grr. The entries are in jdk9/dev. While we have associated nightly
> failures in jdk9/hs-rt - where the tests are still not excluded. So, I
> guess I need to fix this in jdk9/dev and just let the nightly failures
> jdk9/hs-rt be till we get the changes from jdk9/dev. Pretty simple ;)
Updated ProblemList.txt -
http://cr.openjdk.java.net/~jbachorik/8134420/webrev.02
-JB-
>
> -JB-
>
>>
>>> On 4 sep 2015, at 12:34, Staffan Larsen <staffan.larsen at oracle.com>
>>> wrote:
>>>
>>> Good!
>>>
>>>> On 4 sep 2015, at 12:21, Jaroslav Bachorik
>>>> <jaroslav.bachorik at oracle.com> wrote:
>>>>
>>>> On 2.9.2015 20:44, Staffan Larsen wrote:
>>>>> Looks good, but needs a test.
>>>>
>>>> I've modified the 'jps' generic test to exercise multi-lined
>>>> properties.
>>>>
>>>> http://cr.openjdk.java.net/~jbachorik/8134420/webrev.01
>>>>
>>>> -JB-
>>>>
>>>>>
>>>>>> On 2 sep 2015, at 20:21, Jaroslav Bachorik
>>>>>> <jaroslav.bachorik at oracle.com> wrote:
>>>>>>
>>>>>> Please, review the following change
>>>>>>
>>>>>> Issue : https://bugs.openjdk.java.net/browse/JDK-8134420
>>>>>> Webrev: http://cr.openjdk.java.net/~jbachorik/8134420/webrev.00
>>>>>>
>>>>>> Currently, 'jps' will print multi-line vm args as they are - eg.
>>>>>> splitting the output into multiple lines. This kind of output is
>>>>>> not very easy to read and, incidentally, it can break this test.
>>>>>>
>>>>>> My proposal is to replace all '\n' and '\r' characters with "\n"
>>>>>> and "\r" strings respectively to keep the output format being 'one
>>>>>> line per one JVM'.
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> -JB-
>>>>>
>>>>
>>>
>>
>
More information about the serviceability-dev
mailing list