RFR(XS): JDK-8152679 DeadlockDetectionTest.java fails due to expected output missing
Staffan Larsen
staffan.larsen at oracle.com
Fri Apr 8 08:10:35 UTC 2016
Why did this test start failing?
> On 7 apr. 2016, at 20:35, serguei.spitsyn at oracle.com wrote:
>
> Dmitry,
>
> I agree with Tim.
> The message at L85 should not be alarming but look similar to the one at L107.
> Something, like this:
> 85 System.out.println("This test is not expected to work on OS X. Skipping");
>
>
> Thanks,
> Serguei
>
>
> On 4/7/16 11:13, Tim Bell wrote:
>> On 04/07/16 10:56, Dmitry Samersoff wrote:
>>> Everybody,
>>>
>>> Please review small changes.
>>
>> Note: I am not a "R"eviewer in Serviceability. Free advice follows:
>>
>>> http://cr.openjdk.java.net/~dsamersoff/JDK-8152679/webrev.01/
>>>
>>> Test that is not expected to work on OS X, detect OS X and exits.
>>
>> 84 // Coredump stackwalking is not implemented for Darwin
>> 85 System.err.println("Error! This test is not expected to work on OS X.");
>>
>>
>> It is not implemented, so landing here during a test run on Mac OS should not be surprising.
>>
>> Rather than printing 'Error!' I suggest removing that alarming string, as on line 107 .
>>
>> My 0x02 cents.
>>
>> Tim
>>
>>
>
More information about the serviceability-dev
mailing list