RFR(XS): JDK-8152679 DeadlockDetectionTest.java fails due to expected output missing

[serguei.spitsyn at oracle.com]

Dmitry,

+ System.err.println("This test is not expected to work on OS X. 
Skipping"); I think, it has to be System.out, not System err (the same 
as at L107). No need to re-review if you fix it. Thanks, Serguei


On 4/8/16 03:01, Dmitry Samersoff wrote:
> Tim, Serguei,
>
> Thank you for the review.
>
> The message updated (in-place, press shift-reload)
>
> http://cr.openjdk.java.net/~dsamersoff/JDK-8152679/webrev.01/
>
> -Dmitry
>
> On 2016-04-07 21:35, serguei.spitsyn at oracle.com wrote:
>> Dmitry,
>>
>> I agree with Tim.
>> The message at L85 should not be alarming but look similar to the one at
>> L107.
>> Something, like this:
>>    85        System.out.println("This test is not expected to work on OS
>> X. Skipping");
>>
>>
>> Thanks,
>> Serguei
>>
>>
>> On 4/7/16 11:13, Tim Bell wrote:
>>> On 04/07/16 10:56, Dmitry Samersoff wrote:
>>>> Everybody,
>>>>
>>>> Please review small changes.
>>> Note:  I am not a "R"eviewer in Serviceability.  Free advice follows:
>>>
>>>> http://cr.openjdk.java.net/~dsamersoff/JDK-8152679/webrev.01/
>>>>
>>>> Test that is not expected to work on OS X, detect OS X and exits.
>>>    84             // Coredump stackwalking is not implemented for Darwin
>>>    85             System.err.println("Error! This test is not expected
>>> to work on OS X.");
>>>
>>>
>>> It is not implemented, so landing here during a test run on Mac OS
>>> should not be surprising.
>>>
>>> Rather than printing 'Error!' I suggest removing that alarming string,
>>> as on line 107   .
>>>
>>> My 0x02 cents.
>>>
>>> Tim
>>>
>>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20160408/91c27b38/attachment.html>