PING: RFR: JDK-8153073: UL: Set filesize option with k/m/g

Yasumasa Suenaga yasuenag at gmail.com
Mon Apr 11 09:28:55 UTC 2016


PING: Could you review it?
We need more reviewer.

>>     http://cr.openjdk.java.net/~ysuenaga/JDK-8153073/webrev.01/


Thanks,

Yasumasa


On 2016/03/31 22:33, Yasumasa Suenaga wrote:
> CC'ed to serviceability-dev.
> 
> Could you review it?
> 
>>     http://cr.openjdk.java.net/~ysuenaga/JDK-8153073/webrev.01/
> 
> 
> Thanks,
> 
> Yasumasa
> 
> 
> On 2016/03/31 18:24, Yasumasa Suenaga wrote:
>> Hi Marcus,
>>
>>> You're missing an include of arguments.hpp in logFileOutput.cpp.
>>
>> arguments.hpp is included in precompiled.hpp . So build was succeeded.
>> However, it should be included in logFileOutput.cpp .
>>
>> I uploaded a new webrev. Could you review again?
>>
>>     http://cr.openjdk.java.net/~ysuenaga/JDK-8153073/webrev.01/
>>
>>
>> Thanks,
>>
>> Yasumasa
>>
>>
>> On 2016/03/31 16:48, Marcus Larsson wrote:
>>> Hi,
>>>
>>> On 03/30/2016 04:09 PM, Yasumasa Suenaga wrote:
>>>> Hi all,
>>>>
>>>> This request review is related to [1].
>>>>
>>>> I want to set filesize option with k/m/g as below:
>>>>               -Xlog:gc=trace:file=gc.log:time:filecount=5,filesize=10m
>>>>
>>>> Memory size option (e.g. -Xmx) can be set with k/m/g .
>>>> I think we can use option parser in arguments.cpp .
>>>>
>>>> I uploaded webrev. Could you review it?
>>>>
>>>>      http://cr.openjdk.java.net/~ysuenaga/JDK-8153073/webrev.00/
>>>
>>> You're missing an include of arguments.hpp in logFileOutput.cpp.
>>>
>>> Apart from that, this looks good to me.
>>>
>>> Thanks,
>>> Marcus
>>>
>>>>
>>>>
>>>> I cannot access JPRT. So I need a sponsor.
>>>>
>>>>
>>>> Thanks,
>>>>
>>>> Yasumasa
>>>>
>>>>
>>>> [1] http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2016-March/018704.html
>>>>
>>>


More information about the serviceability-dev mailing list