RFR(8u) JDK-8153252: SA: Hotspot build on Windows fails if make/closed folder does not exist

Poonam Bajaj Parhar poonam.bajaj at oracle.com
Mon Apr 11 19:15:19 UTC 2016


Hello,

Please review this simple fix.

Bug JDK-8153252 <https://bugs.openjdk.java.net/browse/JDK-8153252>: SA: 
Hotspot build on Windows fails if make/closed folder does not exist

Problem: The problem is that the SA build on windows fails while 
building non-openjdk commercial sources that don't contain the 
make/closed folder.

nmake -nologo -f D:\ws\8u-dev\hotspot\make\windows\makefiles\top.make BUILD_FLAVOR=product ARCH=x86
nmake in ./generated
         cd generated && "d:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\BIN\nmake.EXE" -NOLOGO -f D:\ws\8u-dev\hotspot\make\windows\makefiles\
generated.make  DIR=.\generated BUILD_FLAVOR=product
D:\ws\8u-dev\hotspot/make/windows/makefiles/sa.make(54) : fatal error U1052: file 'D:\ws\8u-dev\hotspot/make/closed/windows/makefiles/sa.make' not found
Stop.
NMAKE : fatal error U1077: 'cd' : return code '0x2'

Fix: Add a check to ensure that the make/closed folder exists.

Webrev: http://cr.openjdk.java.net/~poonam/8153252/webrev.00/

Thanks,
Poonam

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20160411/f3af0520/attachment.html>


More information about the serviceability-dev mailing list