RFR(XS): JDK-8153856 com/sun/jdi/WatchFramePop.sh fails with exit code 1

[Staffan Larsen]

Thanks for the explanation. The change looks good.

Do you know if the change in jps output was intentional or caused by something else?


> On 12 apr. 2016, at 16:32, Dmitry Samersoff <dmitry.samersoff at oracle.com> wrote:
> 
> Staffan,
> 
> On 2016-04-12 16:32, Staffan Larsen wrote:
>> Can you explain what is going on here? It looks like the old code
>> looked for the TTY process, whereas the new code accepts any process.
>> What am I missing?
> 
> Both code select jdbCmd first:
> 
> ll. 926
> jdbCmd=`$jdk/bin/jps -v | $grep $jdbKeyword`
> 
> then old code expect:
> 
> 12199 TTY -Dapplication.home=/opt/jdk1.8.0_77 -Xms8m
> 
> but for latest JDK9 jps -v return full class name:
> 
> 12281 com.sun.tools.example.debug.tty.TTY -Dapplication.home=/opt/jdk9
> -Xms8m -Djdk.module.main=jdk.jdi
> 
> i.e. we get com.sun.tools.example.debug.tty.TTY instead of just TTY
> 
> new code accept both variants.
> 
> -Dmitry
> 
> 
>> 
>>> On 12 apr. 2016, at 14:28, Dmitry Samersoff
>>> <dmitry.samersoff at oracle.com> wrote:
>>> 
>>> Everybody,
>>> 
>>> Please review a small fix.
>>> 
>>> http://cr.openjdk.java.net/~dsamersoff/JDK-8153856/webrev.01/
>>> 
>>> This fix doesn't fix root cause of the test fail but fix small test
>>> bug to get better diagnostic.
>>> 
>>> -Dmitry
>>> 
>>> -- Dmitry Samersoff Oracle Java development team, Saint Petersburg,
>>> Russia * I would love to change the world, but they won't give me
>>> the sources.
>> 
> 
> 
> -- 
> Dmitry Samersoff
> Oracle Java development team, Saint Petersburg, Russia
> * I would love to change the world, but they won't give me the sources.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20160412/d82bd3e7/attachment.html>