RFR: 8154059: JVMTI ObjectTagging to UL

[Daniel D. Daugherty]

Yup. I saw that after I was caught up with my hg/Mercurial notifications
mailbox... My general (unfiltered) Inbox gets priority since that's where
code review happen... :-)

Dan


On 4/19/16 1:23 PM, Robbin Ehn wrote:
> Hi Dan,
>
> This was pushed with:
>
> -Xlog:jvmti+objecttagging=debug
>
> /Robbin
>
> On 04/19/2016 06:06 PM, Daniel D. Daugherty wrote:
>> Please, no shorter than 'objtag'. Object needs to be in there
>> somewhere... 'tagging' is just too general.
>>
>> Dan
>>
>>
>> On 4/19/16 5:16 AM, Robbin Ehn wrote:
>>> Hi Serguei,
>>>
>>> Thanks!
>>>
>>> /Robbin
>>>
>>> On 04/19/2016 12:05 PM, serguei.spitsyn at oracle.com wrote:
>>>> Hi Robbin,
>>>>
>>>> The fix loos good.
>>>> I'd like to have the tag-set name shorter but prefer "objecttagging"
>>>> over "tagging".
>>>> Also, I'm thinking if the tag-set name should include the "jvmti" 
>>>> prefix.
>>>> But, please, use your judgement as it has to be consistent with the
>>>> overall design.
>>>>
>>>> Thanks,
>>>> Serguei
>>>>
>>>>
>>>> On 4/19/16 02:46, Robbin Ehn wrote:
>>>>> Hi Marcus,
>>>>>
>>>>> On 04/19/2016 11:16 AM, Marcus Larsson wrote:
>>>>>> Hi,
>>>>>>
>>>>>> On 04/14/2016 01:52 PM, Robbin Ehn wrote:
>>>>>>> Hi all,
>>>>>>>
>>>>>>> Please review:
>>>>>>>
>>>>>>> This moves jvmti object-tagging output to the tag-set
>>>>>>> jvmti,objecttagging on debug level.
>>>>>>>
>>>>>>> The TraceJVMTIObjectTagging argument is deprecated and aliased 
>>>>>>> with:
>>>>>>> "-Xlog:jvmti+objecttagging=debug"
>>>>>>>
>>>>>>> Did this on top of:
>>>>>>> http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2016-April/019007.html 
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> but only part common is the jvmti tag (logTag.hpp).
>>>>>>>
>>>>>>> Webrev: http://cr.openjdk.java.net/~rehn/8154059/
>>>>>>
>>>>>> I think 'objecttagging' is a bit too long. Maybe we could just 
>>>>>> call it
>>>>>> 'tagging'? I'm fine with leaving it as is as well, just wanted to
>>>>>> suggest the alternative.
>>>>>
>>>>> If the "second" reviewer concur, I'll change it.
>>>>>
>>>>>>
>>>>>> Looks good in any case!
>>>>>
>>>>> Thanks!
>>>>>
>>>>> /Robbin
>>>>>
>>>>>>
>>>>>> Thanks,
>>>>>> Marcus
>>>>>>
>>>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8154059
>>>>>>>
>>>>>>> Thanks!
>>>>>>>
>>>>>>> /Robbin
>>>>>>>
>>>>>>
>>>>
>>
>