RFR: 8154728: JvmtiExport::add_default_read_edges hits a guarantee

Mikael Gerdin mikael.gerdin at oracle.com
Wed Apr 20 07:51:16 UTC 2016


Hi Robbin,

On 2016-04-20 09:40, Robbin Ehn wrote:
> Hi all,
>
> Please review.
>
> We are missing a cr on a log stream, which leads to this guarantee.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8154728
>
> Thanks !
>
> /Robbin
>
> diff -r 857efca82258 src/share/vm/prims/jvmtiExport.cpp
> --- a/src/share/vm/prims/jvmtiExport.cpp    Sun Apr 17 19:15:52 2016 -0700
> +++ b/src/share/vm/prims/jvmtiExport.cpp    Wed Apr 20 09:37:01 2016 +0200
> @@ -428,6 +428,7 @@
>       LogTarget(Trace, jvmti) log;
>       LogStreamCHeap log_stream(log);
>       java_lang_Throwable::print(PENDING_EXCEPTION, &log_stream);
> +    log_stream.cr();
>       CLEAR_PENDING_EXCEPTION;
>       return;
>     }


Looks good.

/Mikael


More information about the serviceability-dev mailing list