RFR: 8154719: JvmtiBreakpoint rename method print() to print_on()

Robbin Ehn robbin.ehn at oracle.com
Wed Apr 20 11:55:19 UTC 2016


Thanks Marcus!

/Robbin

On 04/20/2016 01:54 PM, Marcus Larsson wrote:
> Hi,
>
> On 04/20/2016 01:47 PM, Robbin Ehn wrote:
>> Hi all, please review!
>>
>> print() method was changed in 8154041 to have outputStream argument,
>> this renames print to print_on.
>> Since JvmtiBreakpoint extends GrowableElement print_on already exists
>> as a virtual const method, hence the const changes.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8154719
>> Webrev: http://cr.openjdk.java.net/~rehn/8154719/webrev/
>
> Looks good to me.
>
> Thanks,
> Marcus
>
>>
>> Tested with:
>>
>> #define TraceJVMTICalls false
>> in hotspot/src/share/vm/prims/jvmtiEnv.cpp
>> set to true with test-set nsk.jvmti.SetBreakpoint
>>
>> Thanks!
>>
>> /Robbin
>


More information about the serviceability-dev mailing list