RFR(S): JDK-8155009 jstack subtest of BasicLauncherTest should not be executed under OS X

Dmitry Samersoff dmitry.samersoff at oracle.com
Mon Apr 25 12:24:59 UTC 2016


Robbin,

On 2016-04-25 15:17, Robbin Ehn wrote:
> Hi Dmitry,
> 
> For separate RFE, wouldn't it be nicer if these 4 tests where split into
> 4 jtreg so we could use in this case:
> 
> @requires ((os.family == "linux") & (os.arch=="amd64")) | (os.family ==
> "solaris")
> 
> instead ?

Yes, I think we should do it someday as well as change other similar tests.

-Dmitry

> 
> Looks good to me!
> 
> /Robbin (not a Reviewer)
> 
> 
> On 04/25/2016 01:45 PM, Dmitry Samersoff wrote:
>> Everybody,
>>
>> Please review the test changes.
>>
>> http://cr.openjdk.java.net/~dsamersoff/JDK-8155009/webrev.01/
>>
>> Coredump stackwalking is not implemented on OS X so skip corresponding
>> test.
>>
>> -Dmitry
>>
>>


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.


More information about the serviceability-dev mailing list