RFR - JDK-8162524 : src/jdk.management/share/native/libmanagement_ext/Flag.c doesn't handle JNI exceptions

[David Holmes]

On 1/08/2016 5:12 PM, Harsha Wardhana B wrote:
> Hello,
>
> Test case is missing. I was under the assumption that test cases are
> mandatory unless it is not possible to write one. If it not possible to
> write test case, shouldn't there be a justification for the same?

noreg-hard would apply here. Extremely difficult to force an OOME at a 
specific point to ensure a given error path is followed.

David

> Regards
>
> Harsha
>
>
> On Monday 01 August 2016 05:47 AM, David Holmes wrote:
>> Hi Amit,
>>
>> On 29/07/2016 7:05 PM, Amit Sapre wrote:
>>> Hello,
>>>
>>> Please review this small fix.
>>>
>>> Bug Id : https://bugs.openjdk.java.net/browse/JDK-8162524
>>>
>>> Webrev : http://cr.openjdk.java.net/~hb/sponsorship/8162524/webrev.00/
>>
>> Looks good to me too.
>>
>> David
>>
>>>
>>>
>>> Thanks,
>>>
>>> Amit
>>>
>