RFR: JDK-8163272: jhsdb jinfo cannot show system properties

[Yasumasa Suenaga]

Hi Jini,

I changed BasicLauncherTest#launch() to handle unexpected message.

   http://cr.openjdk.java.net/~ysuenaga/JDK-8163272/webrev.01/jdk/

Does this change fit to your needs?


Thanks,

Yasumasa


On 2016/08/06 22:37, Jini Susan George wrote:
> Hi Yasumasa,
>
> It would be great if you could modify jdk/test/sun/tools/jhsdb/BasicLauncherTest.java to test for this also as a part of your change.
>
> Thanks,
> Jini. (Not a Reviewer).
>
>> -----Original Message-----
>> From: Yasumasa Suenaga [mailto:yasuenag at gmail.com]
>> Sent: Friday, August 05, 2016 5:30 PM
>> To: serviceability-dev at openjdk.java.net
>> Subject: RFR: JDK-8163272: jhsdb jinfo cannot show system properties
>>
>> Hi all,
>>
>> I tried to get system properties via "jhsdb jinfo".
>> However, it did not work as below:
>>
>> ----------------
>> $ /usr/local/jdk-9/bin/jhsdb jinfo --pid 1002
>> Attaching to process ID 1002, please wait...
>> Debugger attached successfully.
>> Server compiler detected.
>> JVM version is 9-ea+129
>> Java System Properties:
>>
>> java.lang.NullPointerException
>>          at
>> sun.jvm.hotspot.utilities.ObjectReader.getHashtable(jdk.hotspot.agent at 9-
>> ea/ObjectReader.java:217)
>>          at
>> sun.jvm.hotspot.utilities.ObjectReader.readInstance(jdk.hotspot.agent at 9-
>> ea/ObjectReader.java:247)
>>          at
>> sun.jvm.hotspot.utilities.ObjectReader.readObject(jdk.hotspot.agent at 9-
>> ea/ObjectReader.java:105)
>>          at sun.jvm.hotspot.runtime.VM$2.doOop(jdk.hotspot.agent at 9-
>> ea/VM.java:940)
>>          at sun.jvm.hotspot.oops.InstanceKlass.visitField(jdk.hotspot.agent at 9-
>> ea/InstanceKlass.java:872)
>>          at
>> sun.jvm.hotspot.oops.InstanceKlass.iterateStaticFieldsInternal(jdk.hotspot.ag
>> ent at 9-ea/InstanceKlass.java:572)
>>          at
>> sun.jvm.hotspot.oops.InstanceKlass.iterateStaticFields(jdk.hotspot.agent at 9-
>> ea/InstanceKlass.java:560)
>>          at
>> sun.jvm.hotspot.runtime.VM.readSystemProperties(jdk.hotspot.agent at 9-
>> ea/VM.java:935)
>>                 :
>> System Properties info not available!
>> ----------------
>> * If you want to see all stack, please see JBS.
>>
>>
>> I think this is caused by JDK-8029891.
>> JDK-8029891 changes that j.u.Properties stores properties to
>> j.u.c.ConcurrentHashMap.
>> ObjectReader should be adapted to this change.
>>
>> I uploaded webrev. Could you review it?
>>
>>    http://cr.openjdk.java.net/~ysuenaga/JDK-8163272/webrev.00/
>>
>> I'm jdk 9 commiter, but I cannot access JPRT.
>> So I need a sponsor.
>>
>>
>> Thanks,
>>
>> Yasumasa
>>
>>