RFR: JDK-8164319: CLHSDB dumpcodecache throws StackOverflowError

[David Holmes]

On 18/08/2016 11:51 PM, Yasumasa Suenaga wrote:
> Hi all,
>
> I encountered StackOverflowError when I run dumpcodecache command in
> CLHSDB:
>
> ------------
> hsdb> dumpcodecache
> Exception in thread "main" java.lang.StackOverflowError
>         at
> sun.jvm.hotspot.code.CodeBlob.getName(jdk.hotspot.agent at 9-ea/CodeBlob.java:118)
>
>         at
> sun.jvm.hotspot.code.CodeBlob.getName(jdk.hotspot.agent at 9-ea/CodeBlob.java:118)
>
>         at
> sun.jvm.hotspot.code.CodeBlob.getName(jdk.hotspot.agent at 9-ea/CodeBlob.java:118)
>
>         at
> sun.jvm.hotspot.code.CodeBlob.getName(jdk.hotspot.agent at 9-ea/CodeBlob.java:118)
>
>         at
> sun.jvm.hotspot.code.CodeBlob.getName(jdk.hotspot.agent at 9-ea/CodeBlob.java:118)
>
>             :
> ------------
>
> CodeBlob#getName() calls itself recursively.
> Thus it occurs StackOverflowError.
> http://hg.openjdk.java.net/jdk9/hs/hotspot/file/e99e410e78e1/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/CodeBlob.java#l117
>
>
> I uploaded webrev for this issue.
> Could you reivew it?
>
>   http://cr.openjdk.java.net/~ysuenaga/JDK-8164319/webrev.00/

Looks good. Bug was introduced by a refactoring of the code.

> I also need a sponsor.

Will do so if noone else claims it before the US weekend. :)

Thanks,
David

>
> Thanks,
>
> Yasumasa