RFR:(S): 8164562: serviceability/sa/TestInstanceKlassSizeForInterface.java: fails with NPE

David Holmes david.holmes at oracle.com
Mon Aug 29 04:06:12 UTC 2016


On 24/08/2016 4:10 PM, Jini Susan George wrote:
> Hi all,
>
> Could you please review the fix for:
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8164562
>
> Webrev: http://cr.openjdk.java.net/~jgeorge/8164562/webrev.00/
>
> I took the liberty to do some module related cleanups in the test also
> while fixing this issue.

So which change fixes the actual bug?

As far as I can see if the output of the command is not as expected we 
return a null and that then leads to the NPE when calling 
String.contains. Seems to me that the test should be more resilient here 
and give a meaningful error message if the expected output is not seen.

Thanks,
David

>
>
> Thank you,
>
> - Jini Susan George
>
>
>


More information about the serviceability-dev mailing list