RFR:(S): 8164562: serviceability/sa/TestInstanceKlassSizeForInterface.java: fails with NPE

David Holmes david.holmes at oracle.com
Tue Aug 30 06:07:33 UTC 2016


Hi Mandy,

On 30/08/2016 3:56 PM, Mandy Chung wrote:
>
>> On Aug 29, 2016, at 12:51 AM, Jini Susan George <jini.george at oracle.com> wrote:
>>
>> Hi David,
>>
>> Thank you for the review. I have added a few more asserts and uploaded a modified webrev:
>>
>> http://cr.openjdk.java.net/~jgeorge/8164562/webrev.01/
>
> Looks okay.  It’d be helpful if you can make sure your fix can push to jdk9/hs and include in the next hs->dev push.  Otherwise these tests without your fix will fail in jdk9/dev since the old CLI option will be removed.

Why wasn't removal deferred until after all test changes were made? 
There is no guarantees as to when jdk9/hs will push up next - it depends 
on the changes that go in there and the stability of those changes.

David

> thanks
> Mandy
>


More information about the serviceability-dev mailing list